ngraham requested changes to this revision. ngraham added inline comments. This revision now requires changes to proceed.
INLINE COMMENTS > WidgetExplorer.qml:295 > keyNavigationWraps: true > - cellWidth: (width - units.smallSpacing) / 2 > + cellWidth: Math.round((width - units.smallSpacing) / 2) > cellHeight: cellWidth + units.gridUnit * 4 + units.smallSpacing > * 2 In general it's best to use `floor` rather than `round` for this kind of thing to prevent everything from getting rounded up and potentially overflowing the bounds. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D21030 To: filipf, #plasma, #vdg, ngraham Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart