sitter accepted this revision.
sitter added a comment.
LGTM. At a glance breezehelper caches values (loadConfig) and
brezestyleconfigdata may as well, so this certainly seems sound. Specifically `
_viewFocusBrush = KStatefulBrush( KColorScheme::View,
KColorScheme::FocusColor, _config );` seems to be used to influence the focus
color of checkboxes and that _config is in fact a StyleConfigData. So, this
definitely needs a reload.
Is integration of qt4 software still a concern? If so, perhaps the colors KCM
should also send the reparseConfiguration signal, seeing as that would cause a
double reload on Qt5 we probably don't want that though.
REPOSITORY
R31 Breeze
BRANCH
colorchangeeventfilter
REVISION DETAIL
https://phabricator.kde.org/D21646
To: sebas, #plasma, broulik, sitter
Cc: sitter, cfeck, broulik, zzag, plasma-devel, LeGast00n, ericadams, jraleigh,
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart
