kossebau added inline comments.

INLINE COMMENTS

> main.cpp:89
>                           QStringLiteral("sp...@kde.org"));
> +    KAboutData::setApplicationData(aboutData);
>      qa.setWindowIcon(QIcon::fromTheme(QStringLiteral("tools-report-bug"), 
> qa.windowIcon()));

This is partially redundant though with all the QCoreApplication::set* above, 
as well as qa.setDesktopFileName below. Those should be removed then for clean 
code.

REPOSITORY
  R871 DrKonqi

BRANCH
  Plasma/5.16

REVISION DETAIL
  https://phabricator.kde.org/D21799

To: sitter, #plasma, davidedmundson
Cc: kossebau, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

Reply via email to