ngraham added a comment.
In D10362#488571 <https://phabricator.kde.org/D10362#488571>, @ndavis wrote: > In D10362#488389 <https://phabricator.kde.org/D10362#488389>, @ngraham wrote: > > > I think the idea is that you're not supposed to be typing with the characters visible as you type because then anyone else who might be around could just see your password. > > > I understand this, but I think this is one of those cases where a marginal increase in security should take a backseat to usability. It's not like people can't quickly hide the password again if they already know about the button. If one is afraid of others looking over their shoulder, they shouldn't use the reveal password button in the first place, regardless of how it functions. Yeah, I guess that makes sense. REPOSITORY R242 Plasma Framework (Library) BRANCH change-reveal-password-button-logic (branched from master) REVISION DETAIL https://phabricator.kde.org/D10362 To: GB_2, #plasma, #vdg, ngraham, broulik Cc: ndavis, kde-frameworks-devel, rizzitello, elvisangelaccio, ngraham, starbuck, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, michaelh, ZrenBot, bruns, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
