mthw added a comment.
In D22452#495325 <https://phabricator.kde.org/D22452#495325>, @ngraham wrote: > Whether or not it's better is not relevant for this patch, which right now is only about fixing the text color. It's best not to mix multiple changes like this, unless you want to expand the patch in scope, in which case it should be re-titled accordingly. > > Still, I would recommend doing one change per patch, because it makes each one more likely to get in compared to patches with multiple changes (especially when any one of those individual changes may be controversial or require discussion). If I did re-title and change the description, would this have a better chance of passing? The chage is so small (number of lines) that It probably wouldn't make sense to split it. If not, then I am stuck and I have clearly bitten more than I can chew. REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D22452 To: mthw, #vdg, #breeze, ndavis, ngraham Cc: cblack, ndavis, zzag, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
