hein added a comment.
I see what this is trying to do, but some of the details seem a bit wrong. E.g. you're only setting `dragging` to false in a code branch that's only executed when it already is false, which means it's not going to be set to false on a drag release, and pressX/Y also won't be unset on a release that doesn't happen above an iten anymore. You can keep the code flow change (the main thing this is probably fixing is that wrong check for the return value of `updatePositionProperties`), but please rework the patch a bit to make sure that the state of these variables still gets updated in the way they should on a release. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D22306 To: luc4, ngraham, trmdi, #plasma Cc: hein, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
