filipf added inline comments. INLINE COMMENTS
> davidedmundson wrote in sddmauthhelper.cpp:119 > Task for another day, we don't need to pass this in every time. > > We can set this at compile time, using the same values from config.h as the > KCM would use +1 > davidedmundson wrote in advanceconfig.cpp:205 > why? I need the identifier to delete the entry in the config file (done in sddmauthhelper.cpp), the value is not important so I just set whatever. Any smarter way of doing this? > davidedmundson wrote in advanceconfig.ui:220 > that seems odd? Definitely does, QtDesigner can be weird. Going to undo that. REPOSITORY R123 SDDM Configuration Panel (KCM) REVISION DETAIL https://phabricator.kde.org/D22363 To: filipf, ngraham, davidedmundson Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart