zzag accepted this revision. zzag added a comment. This revision is now accepted and ready to land.
KRunners isn't my thing, but I had been working as a backend web developer for quite a while. INLINE COMMENTS > firefox.cpp:98 > } > - QList<QVariantMap> results = m_fetchsqlite->query(query, QMap<QString, > QVariant>()); > + QMap<QString,QVariant> bindVariables > + {{QStringLiteral(":term"), QStringLiteral("%%%1%%").arg(term)}}; Missing const + whitespace between comma and QVariant, i.e. const QMap<QString, QVariant> bindVariables { { QStringLiteral(":term"), QStringLiteral("%%%1%%").arg(term) }, }; REPOSITORY R120 Plasma Workspace BRANCH Plasma/5.16 REVISION DETAIL https://phabricator.kde.org/D22623 To: fvogt, #plasma, zzag Cc: zzag, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart