Marcus, as you are a committer for platform you should be able to assign reviewers to your PRs
On Wed, May 18, 2022 at 2:54 PM Hoepfner, Marcus via platform-dev < platform-dev@eclipse.org> wrote: > I don’t even see proposals for reviewers. > > > > *From: *platform-dev <platform-dev-boun...@eclipse.org> on behalf of Ed > Merks <ed.me...@gmail.com> > *Date: *Wednesday, 18. May 2022 at 14:45 > *To: *platform-dev@eclipse.org <platform-dev@eclipse.org> > *Subject: *Re: [platform-dev] Cannot push to github g...@github.com: > eclipse-platform/eclipse.platform.ui.git > > Marcus, > > I got a notification like this: > > This issue of not being able to assign a reviewer came up recently too. > I'm not sure how that's being resolved. But I do think committers will > generally be notified so hopefully one of them adds themself. > > Do you see this part? > > I suppose you could add a comment with @vogella to send a more directed > notification... > > > > > > On 18.05.2022 14:40, Hoepfner, Marcus via platform-dev wrote: > > Thanks. > > > > I have created a fork and a PR now on > https://github.com/eclipse-platform/eclipse.platform.ui > <https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Feclipse-platform%2Feclipse.platform.ui&data=05%7C01%7Cmarcus.hoepfner%40sap.com%7C7e1e99d5203c40f186b208da38cc546b%7C42f7676cf455423c82f6dc2d99791af7%7C0%7C0%7C637884747497888699%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=uQW5c4UUo%2FZnRyBsRkTKhmmnxGUyuzgNPr0IqxSRalE%3D&reserved=0> > . > > Unfortunately I cannot add Reviewers to the PR. > > > > Guess that’s because I’m not contributor in platform.ui? > > > > *From: *platform-dev <platform-dev-boun...@eclipse.org> > <platform-dev-boun...@eclipse.org> on behalf of Ed Merks > <ed.me...@gmail.com> <ed.me...@gmail.com> > *Date: *Wednesday, 18. May 2022 at 13:44 > *To: *platform-dev@eclipse.org <platform-dev@eclipse.org> > <platform-dev@eclipse.org> > *Subject: *Re: [platform-dev] Cannot push to github > g...@github.com:eclipse-platform/eclipse.platform.ui.git > > The more detailed instructions are here: > > > https://github.com/eclipse-platform/.github/blob/main/CONTRIBUTING.md#recommended-workflow > <https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Feclipse-platform%2F.github%2Fblob%2Fmain%2FCONTRIBUTING.md%23recommended-workflow&data=05%7C01%7Cmarcus.hoepfner%40sap.com%7C7e1e99d5203c40f186b208da38cc546b%7C42f7676cf455423c82f6dc2d99791af7%7C0%7C0%7C637884747497888699%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=GqGNUNRt1V6sZsG9CJo0wis4SB%2FtNcgqBvQwdqtGiy8%3D&reserved=0> > > Yes, you should use a fork with pull requests. > > I generally clone the "real" repository and create an additional remote > that points at my fork: > > I leave master hooked up to origin/master and create a local branch that I > push to my fork remote. When I'm done I check out master again and can > always pull from the real original clone (so no need to manually sync my > fork with the original). > > > > On 18.05.2022 13:36, Hoepfner, Marcus via platform-dev wrote: > > Hi, > > > > did not follow all the discussion how to contribute after moved to github. > > > > Do I need to fork or can I push to new branch in > g...@github.com:eclipse-platform/eclipse.platform.ui.git? > > How do I become contributer in that repo? > > > > I want to develop a feature, not about a bug fix. > > > > > https://github.com/eclipse-platform/eclipse.platform.ui/blob/master/CONTRIBUTING.md > <https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Feclipse-platform%2Feclipse.platform.ui%2Fblob%2Fmaster%2FCONTRIBUTING.md&data=05%7C01%7Cmarcus.hoepfner%40sap.com%7C7e1e99d5203c40f186b208da38cc546b%7C42f7676cf455423c82f6dc2d99791af7%7C0%7C0%7C637884747497888699%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=omd4i5iBbXtJxaAvbt8PetFOglF3H4ddbJBz%2B4hZufg%3D&reserved=0> > does not really say a lot and points to a wiki page which is talking about > gerrit. > > > > Thanks, Marcus > > > > > _______________________________________________ > > platform-dev mailing list > > platform-dev@eclipse.org > > To unsubscribe from this list, visit > https://www.eclipse.org/mailman/listinfo/platform-dev > <https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.eclipse.org%2Fmailman%2Flistinfo%2Fplatform-dev&data=05%7C01%7Cmarcus.hoepfner%40sap.com%7C7e1e99d5203c40f186b208da38cc546b%7C42f7676cf455423c82f6dc2d99791af7%7C0%7C0%7C637884747497888699%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=rZANXutuWb2bXno8cO8yLvjxG%2F6rj5%2BSX8RUdVehCkU%3D&reserved=0> > > > > _______________________________________________ > > platform-dev mailing list > > platform-dev@eclipse.org > > To unsubscribe from this list, visit > https://www.eclipse.org/mailman/listinfo/platform-dev > <https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.eclipse.org%2Fmailman%2Flistinfo%2Fplatform-dev&data=05%7C01%7Cmarcus.hoepfner%40sap.com%7C7e1e99d5203c40f186b208da38cc546b%7C42f7676cf455423c82f6dc2d99791af7%7C0%7C0%7C637884747497888699%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=rZANXutuWb2bXno8cO8yLvjxG%2F6rj5%2BSX8RUdVehCkU%3D&reserved=0> > > _______________________________________________ > platform-dev mailing list > platform-dev@eclipse.org > To unsubscribe from this list, visit > https://www.eclipse.org/mailman/listinfo/platform-dev > -- Eclipse Platform project co-lead CEO vogella GmbH Haindaalwisch 17a, 22395 Hamburg Amtsgericht Hamburg: HRB 127058 Geschäftsführer: Lars Vogel, Jennifer Nerlich de Vogel USt-IdNr.: DE284122352 Fax (040) 5247 6322, Email: lars.vo...@vogella.com, Web: http://www.vogella.com
_______________________________________________ platform-dev mailing list platform-dev@eclipse.org To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/platform-dev
