Hu there, indeed I was surprised by this change to be merged without review https://github.com/eclipse-platform/eclipse.platform.text/pull/175
I left comment after-the-fact here: https://github.com/mickaelistria/eclipse.platform.text/commit/9515786e802f59563010d395caa90260bb65e95b Would be good if someone could take a second look. Best Sebastian On Thu, Mar 30, 2023 at 1:58 PM Hoepfner, Marcus via platform-dev < platform-dev@eclipse.org> wrote: > Why are you asking? Did you see a concrete issue in particular? > I general I’d not commit without code review. I usually get helpful > comments. > And even it is just about a typo in Javadoc, it is worth it. > > > A colleague once said, code review is kind of deferred pair programming. I > like that, though it might not be 100% correct. > > > > > > On Thu, Mar 30, 2023 at 1:40 PM Sebastian Zarnekow < > sebastian.zarne...@gmail.com> wrote: > > Hi there, > > > > It might be my poor understanding of the current process, so I'm asking > here on the mailing list: > > Are reviews a prerequisite for stuff that's supposed to be merged into > platform? > > > > A working build+test is usually a requirement. Peer reviews are not a > prerequisite for committers, but it's still a good practice to get someone > else to look at a patch before merging, even for committers. For > non-committers, a review/approval from a committer is a requirement before > a merge anyway. > > HTH > _______________________________________________ > platform-dev mailing list > platform-dev@eclipse.org > To unsubscribe from this list, visit > https://www.eclipse.org/mailman/listinfo/platform-dev >
_______________________________________________ platform-dev mailing list platform-dev@eclipse.org To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/platform-dev
