Hello,

It is observed scu ipc driver initialized later than other drivers which are 
using scu ipc interface (Ex, scu ipc driver initialized after GPIO driver). 
This behavior is observed after scu ipc driver moved from arch/x86/kernel to 
drivers/platform/x86. We will work out solution for this

--Sreedhara

-----Original Message-----
From: Matthew Garrett [mailto:[email protected]] 
Sent: Friday, May 28, 2010 7:20 PM
To: Ds, Sreedhara
Cc: [email protected]; [email protected]; Alan Cox
Subject: Re: Patch [3/4] intel scu ipc

On Fri, May 28, 2010 at 02:12:35PM +0530, Ds, Sreedhara wrote:

> -module_init(intel_scu_ipc_init);
> -module_exit(intel_scu_ipc_exit);
> +fs_initcall(intel_scu_ipc_init);

This doesn't look right at all. fs_initcall is certainly wrong, and 
you've also broken the ability to use this as a module without removing 
any of the other module-specific code. Shouldn't other ipc drivers all 
be depending on this one?

-- 
Matthew Garrett | [email protected]
--
To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" 
in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to