On Wed, Jul 07, 2010 at 08:21:48AM +0800, Axel Lin wrote: > In current implementation, acpi_pcc_write_sset return 1 > if write is successful, 0 if write is failed. > But all the callers consider acpi_pcc_write_sset return 0 > if write is successful and return negtive if write is failed. > > This patch changes the implementation of acpi_pcc_write_sset to > return 0 if write is successful, -EIO if write is failed. > > Signed-off-by: Axel Lin <[email protected]> > --- > drivers/platform/x86/panasonic-laptop.c | 7 ++----- > 1 files changed, 2 insertions(+), 5 deletions(-) > > diff --git a/drivers/platform/x86/panasonic-laptop.c > b/drivers/platform/x86/panasonic-laptop.c > index 2fb9a32..ec01c3d 100644 > --- a/drivers/platform/x86/panasonic-laptop.c > +++ b/drivers/platform/x86/panasonic-laptop.c > @@ -248,7 +248,7 @@ static int acpi_pcc_write_sset(struct pcc_acpi *pcc, int > func, int val) > status = acpi_evaluate_object(pcc->handle, METHOD_HKEY_SSET, > ¶ms, NULL); > > - return status == AE_OK; > + return (status == AE_OK) ? 0 : -EIO; > } > > static inline int acpi_pcc_get_sqty(struct acpi_device *device) > @@ -586,7 +586,6 @@ static int acpi_pcc_init_input(struct pcc_acpi *pcc) > static int acpi_pcc_hotkey_resume(struct acpi_device *device) > { > struct pcc_acpi *pcc = acpi_driver_data(device); > - acpi_status status = AE_OK; > > if (device == NULL || pcc == NULL) > return -EINVAL;
Looks good, but why don't you also kill these useless checks while you are at it? Otherwise: Acked-by: Dmitry Torokhov <[email protected]> Thanks. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
