Looks fine to me. Acked-by: Jonathan Woithe <[email protected]>
> The following symbols are needlessly defined global: > > logolamp_led > kblamps_led > > This patch makes the symbols static. > > Signed-off-by: Axel Lin <[email protected]> > --- > drivers/platform/x86/fujitsu-laptop.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/platform/x86/fujitsu-laptop.c > b/drivers/platform/x86/fujitsu-laptop.c > index e325aeb..a758d59 100644 > --- a/drivers/platform/x86/fujitsu-laptop.c > +++ b/drivers/platform/x86/fujitsu-laptop.c > @@ -182,7 +182,7 @@ static enum led_brightness logolamp_get(struct > led_classdev *cdev); > static void logolamp_set(struct led_classdev *cdev, > enum led_brightness brightness); > > -struct led_classdev logolamp_led = { > +static struct led_classdev logolamp_led = { > .name = "fujitsu::logolamp", > .brightness_get = logolamp_get, > .brightness_set = logolamp_set > @@ -192,7 +192,7 @@ static enum led_brightness kblamps_get(struct > led_classdev *cdev); > static void kblamps_set(struct led_classdev *cdev, > enum led_brightness brightness); > > -struct led_classdev kblamps_led = { > +static struct led_classdev kblamps_led = { > .name = "fujitsu::kblamps", > .brightness_get = kblamps_get, > .brightness_set = kblamps_set > -- > 1.5.4.3 > > > -- To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
