On Sun, 8 Aug 2010 00:01:12 +0200 Dan Carpenter <[email protected]> wrote:
> There is a potential NULL dereference of "limits." We can just return > NULL earlier to avoid it. The caller already handles NULL returns. > > Signed-off-by: Dan Carpenter <[email protected]> > > diff --git a/drivers/platform/x86/intel_ips.c > b/drivers/platform/x86/intel_ips.c > index afe82e5..c908048 100644 > --- a/drivers/platform/x86/intel_ips.c > +++ b/drivers/platform/x86/intel_ips.c > @@ -1342,8 +1342,10 @@ static struct ips_mcp_limits *ips_detect_cpu(struct > ips_driver *ips) > limits = &ips_lv_limits; > else if (strstr(boot_cpu_data.x86_model_id, "CPU U")) > limits = &ips_ulv_limits; > - else > + else { > dev_info(&ips->dev->dev, "No CPUID match found.\n"); > + goto out; > + } > > rdmsrl(TURBO_POWER_CURRENT_LIMIT, turbo_power); > tdp = turbo_power & TURBO_TDP_MASK; Yep, good idea to catch this case. Reviewed-by: Jesse Barnes <[email protected]> -- Jesse Barnes, Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
