On Tue, 17 Aug 2010 18:57:25 +0900 (JST), Ryusuke Konishi wrote:
> Hi,
> 
> I got the following error during compiling 2.6.36-rc1.
> 
> > ERROR: "led_classdev_register" [drivers/platform/x86/toshiba_acpi.ko] 
> > undefined!
> > ERROR: "led_classdev_unregister" [drivers/platform/x86/toshiba_acpi.ko] 
> > undefined!
> > make[1]: *** [__modpost] Error 1
> > make: *** [modules] Error 2
> 
> Is anyone looking at this issue ?

This turns out to be a Kconfig dependency problem introduced by commit
6c3f6e6c ("toshiba-acpi: Add support for Toshiba Illumination.")

The following patch fixes it.

Ryusuke Konishi

---
From: Ryusuke Konishi <[email protected]>

toshiba-acpi: fix build error due to missing Kconfig dependency

The commit 6c3f6e6c ("toshiba-acpi: Add support for Toshiba
Illumination.") introduced dependency on NEW_LEDS and LEDS_CLASS, so
it should be added to the Kconfig file.

> ERROR: "led_classdev_register" [drivers/platform/x86/toshiba_acpi.ko] 
> undefined!
> ERROR: "led_classdev_unregister" [drivers/platform/x86/toshiba_acpi.ko] 
> undefined!
> make[1]: *** [__modpost] Error 1
> make: *** [modules] Error 2

Signed-off-by: Ryusuke Konishi <[email protected]>
Cc: Pierre Ducroquet <[email protected]>
Cc: [email protected]
Cc: Matthew Garrett <[email protected]>
---
 drivers/platform/x86/Kconfig |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
index 044f430..5c3f044 100644
--- a/drivers/platform/x86/Kconfig
+++ b/drivers/platform/x86/Kconfig
@@ -490,6 +490,8 @@ config ACPI_TOSHIBA
        depends on RFKILL || RFKILL = n
        select INPUT_POLLDEV
        select BACKLIGHT_CLASS_DEVICE
+       select NEW_LEDS
+       select LEDS_CLASS
        ---help---
          This driver adds support for access to certain system settings
          on "legacy free" Toshiba laptops.  These laptops can be recognized by
-- 
1.6.6.2

--
To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" 
in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to