On Sun, 28 Nov 2010, Thadeu Lima de Souza Cascardo wrote: > While looking for the duplicates in /sys/class/wmi/, I couldn't find > them. The code that looks for duplicates uses strncmp in a binary GUID, > which may contain zero bytes. The right function is memcmp, which is > also used in another section of wmi code. > > It was finding 49142400-C6A3-40FA-BADB-8A2652834100 as a duplicate of > 39142400-C6A3-40FA-BADB-8A2652834100. Since the first byte is the fourth > printed, they were found as equal by strncmp. > > Signed-off-by: Thadeu Lima de Souza Cascardo <[email protected]> > --- > drivers/platform/x86/wmi.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/platform/x86/wmi.c b/drivers/platform/x86/wmi.c > index 104b77c..aecd9a9 100644 > --- a/drivers/platform/x86/wmi.c > +++ b/drivers/platform/x86/wmi.c > @@ -755,7 +755,7 @@ static bool guid_already_parsed(const char *guid_string) > struct wmi_block *wblock; > > list_for_each_entry(wblock, &wmi_block_list, list) > - if (strncmp(wblock->gblock.guid, guid_string, 16) == 0) > + if (memcmp(wblock->gblock.guid, guid_string, 16) == 0) > return true; > > return false; >
Looks right to me. -- Jesper Juhl <[email protected]> http://www.chaosbits.net/ Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html Plain text mails only, please. -- To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
