On Wed, Dec 8, 2010 at 10:28 AM, Sedat Dilek <[email protected]> wrote: > On Wed, Dec 8, 2010 at 10:12 AM, Corentin Chary > <[email protected]> wrote: >> On Wed, Dec 8, 2010 at 9:17 AM, Sedat Dilek <[email protected]> >> wrote: >>> Hi, >>> >>> just wanted to build a new linux-next and see this: >>> >>> [ setup.log ] >>> ... >>> dileks.1" make -C 'debian/build/source_i386_none' >>> O='/home/sd/src/linux-2.6/linux-2.6.37-rc5/debian/build/build_i386_none_686' >>> oldnoconfig >>> make[2]: Entering directory >>> `/home/sd/src/linux-2.6/linux-2.6.37-rc5/debian/build/source_i386_none' >>> HOSTCC scripts/basic/fixdep >>> HOSTCC scripts/basic/docproc >>> GEN >>> /home/sd/src/linux-2.6/linux-2.6.37-rc5/debian/build/build_i386_none_686/Makefile >>> HOSTCC scripts/kconfig/conf.o >>> HOSTCC scripts/kconfig/kxgettext.o >>> SHIPPED scripts/kconfig/zconf.tab.c >>> SHIPPED scripts/kconfig/lex.zconf.c >>> SHIPPED scripts/kconfig/zconf.hash.c >>> HOSTCC scripts/kconfig/zconf.tab.o >>> HOSTLD scripts/kconfig/conf >>> scripts/kconfig/conf --oldnoconfig Kconfig >>> drivers/platform/x86/Kconfig:422:error: recursive dependency detected! >>> drivers/platform/x86/Kconfig:422: symbol EEEPC_WMI depends on ACPI_WMI >>> drivers/platform/x86/Kconfig:438: symbol ACPI_WMI is selected by >>> ACER_WMI >>> drivers/platform/x86/Kconfig:18: symbol ACER_WMI depends on >>> LEDS_CLASS >>> drivers/leds/Kconfig:10: symbol LEDS_CLASS is selected by EEEPC_WMI >>> warning: (ADB_PMU_LED && MACINTOSH_DRIVERS && ADB_PMU || ATH5K && >>> NETDEVICES && WLAN && ATH_COMMON && (PCI || ATHEROS_AR231X) && >>> MAC80211 || ATH9K && NETDEVICES && WLAN && ATH_COMMON && PCI && >>> MAC80211 || ATH9K_HTC && NETDEVICES && WLAN && ATH_COMMON && USB && >>> MAC80211 || CARL9170_LEDS && NETDEVICES && WLAN && ATH_COMMON && >>> CARL9170 || INPUT_WISTRON_BTNS && !S390 && INPUT && INPUT_MISC && X86 >>> && !X86_64 || SENSORS_APPLESMC && HWMON && INPUT && X86 || >>> SENSORS_LIS3LV02D && HWMON && ACPI && INPUT || IR_WINBOND_CIR && >>> MEDIA_SUPPORT && X86 && PNP && RC_CORE || BACKLIGHT_ADP8860 && >>> HAS_IOMEM && BACKLIGHT_LCD_SUPPORT && BACKLIGHT_CLASS_DEVICE && I2C || >>> MSM_STAGING && STAGING && !STAGING_EXCLUDE_BUILD && FB && ARCH_MSM && >>> !FB_MSM || ASUS_LAPTOP && X86 && X86_PLATFORM_DEVICES && ACPI && >>> !ACPI_ASUS && INPUT && (RFKILL || RFKILL=n) || THINKPAD_ACPI && X86 && >>> X86_PLATFORM_DEVICES && ACPI && INPUT && (RFKILL || RFKILL=n) || >>> EEEPC_LAPTOP && X86 && X86_PLATFORM_DEVICES && ACPI && INPUT && >>> EXPERIMENTAL && (RFKILL || RFKILL=n) && HOTPLUG_PCI || EEEPC_WMI && >>> X86 && X86_PLATFORM_DEVICES && ACPI_WMI && INPUT && EXPERIMENTAL && >>> BACKLIGHT_CLASS_DEVICE && (RFKILL || RFKILL=n)) selects LEDS_CLASS >>> which has unmet direct dependencies (NEW_LEDS) >>> # >>> # configuration written to .config >>> # >>> make[2]: Leaving directory >>> `/home/sd/src/linux-2.6/linux-2.6.37-rc5/debian/build/source_i386_none' >>> env -u ABINAME -u ARCH -u FEATURESET -u FLAVOUR -u VERSION -u >>> LOCALVERSION DISTRIBUTION_OFFICIAL_BUILD=1 >>> [email protected] >>> DISTRIBUTION_VERSION="2.6.37~rc5-1~next20101208.dileks.1" make -C >>> 'debian/build/source_i386_none' >>> O='/home/sd/src/linux-2.6/linux-2.6.37-rc5/debian/build/build_i386_none_686' >>> prepare >>> make[2]: Entering directory >>> `/home/sd/src/linux-2.6/linux-2.6.37-rc5/debian/build/source_i386_none' >>> GEN >>> /home/sd/src/linux-2.6/linux-2.6.37-rc5/debian/build/build_i386_none_686/Makefile >>> scripts/kconfig/conf --silentoldconfig Kconfig >>> drivers/platform/x86/Kconfig:422:error: recursive dependency detected! >>> drivers/platform/x86/Kconfig:422: symbol EEEPC_WMI depends on ACPI_WMI >>> drivers/platform/x86/Kconfig:438: symbol ACPI_WMI is selected by >>> ACER_WMI >>> drivers/platform/x86/Kconfig:18: symbol ACER_WMI depends on >>> LEDS_CLASS >>> drivers/leds/Kconfig:10: symbol LEDS_CLASS is selected by EEEPC_WMI >>> warning: (ADB_PMU_LED && MACINTOSH_DRIVERS && ADB_PMU || ATH5K && >>> NETDEVICES && WLAN && ATH_COMMON && (PCI || ATHEROS_AR231X) && >>> MAC80211 || ATH9K && NETDEVICES && WLAN && ATH_COMMON && PCI && >>> MAC80211 || ATH9K_HTC && NETDEVICES && WLAN && ATH_COMMON && USB && >>> MAC80211 || CARL9170_LEDS && NETDEVICES && WLAN && ATH_COMMON && >>> CARL9170 || INPUT_WISTRON_BTNS && !S390 && INPUT && INPUT_MISC && X86 >>> && !X86_64 || SENSORS_APPLESMC && HWMON && INPUT && X86 || >>> SENSORS_LIS3LV02D && HWMON && ACPI && INPUT || IR_WINBOND_CIR && >>> MEDIA_SUPPORT && X86 && PNP && RC_CORE || BACKLIGHT_ADP8860 && >>> HAS_IOMEM && BACKLIGHT_LCD_SUPPORT && BACKLIGHT_CLASS_DEVICE && I2C || >>> MSM_STAGING && STAGING && !STAGING_EXCLUDE_BUILD && FB && ARCH_MSM && >>> !FB_MSM || ASUS_LAPTOP && X86 && X86_PLATFORM_DEVICES && ACPI && >>> !ACPI_ASUS && INPUT && (RFKILL || RFKILL=n) || THINKPAD_ACPI && X86 && >>> X86_PLATFORM_DEVICES && ACPI && INPUT && (RFKILL || RFKILL=n) || >>> EEEPC_LAPTOP && X86 && X86_PLATFORM_DEVICES && ACPI && INPUT && >>> EXPERIMENTAL && (RFKILL || RFKILL=n) && HOTPLUG_PCI || EEEPC_WMI && >>> X86 && X86_PLATFORM_DEVICES && ACPI_WMI && INPUT && EXPERIMENTAL && >>> BACKLIGHT_CLASS_DEVICE && (RFKILL || RFKILL=n)) selects LEDS_CLASS >>> which has unmet direct dependencies (NEW_LEDS) >>> Using /home/sd/src/linux-2.6/linux-2.6.37-rc5/debian/build/source_i386_none >>> as source for kernel >>> GEN >>> /home/sd/src/linux-2.6/linux-2.6.37-rc5/debian/build/build_i386_none_686/Makefile >>> CHK include/linux/version.h >>> UPD include/linux/version.h >>> CHK include/generated/utsrelease.h >>> UPD include/generated/utsrelease.h >>> CC kernel/bounds.s >>> GEN include/generated/bounds.h >>> CC arch/x86/kernel/asm-offsets.s >>> GEN include/generated/asm-offsets.h >>> CALL >>> /home/sd/src/linux-2.6/linux-2.6.37-rc5/debian/build/source_i386_none/scripts/checksyscalls.sh >>> make[2]: Leaving directory >>> `/home/sd/src/linux-2.6/linux-2.6.37-rc5/debian/build/source_i386_none' >>> make[1]: Leaving directory `/home/sd/src/linux-2.6/linux-2.6.37-rc5' >>> >>> Regards, >>> - Sedat - >>> -- >>> To unsubscribe from this list: send the line "unsubscribe >>> platform-driver-x86" in >>> the body of a message to [email protected] >>> More majordomo info at http://vger.kernel.org/majordomo-info.html >>> >> >> Hum ... >> ACER_WMI: >> select ACPI_WMI >> depends on LEDS_CLASS >> depends on NEW_LEDS >> >> EEEPC_WMI: >> depends on ACPI_WMI >> select LEDS_CLASS >> select NEW_LEDS >> >> I don't really see how it's a recursive dependency, but maybe it's >> time to clean this KConfig. >> What is our current policy about that ? >> >> I think we should *depends* on important subsystem (ACPI, INPUT, ...) >> and select obscure things so >> that the driver does not get lost if you don't enable the leds. >> >> depends: >> - ACPI >> - INPUT >> - EXPERIMENTAL >> - RFKILL >> - ACPI_WMI ? >> - HWMON ? >> - THERMAL ? >> >> select: >> - BACKLIGHT_CLASS_* >> - LEDS_CLASS >> - NEW_LEDS >> - INPUT_* >> >> -- >> Corentin Chary >> http://xf.iksaif.net >> > > The last 3 commits touching drivers/platform/x86/Kconfig: > > $ git log -3 drivers/platform/x86/Kconfig > > commit 8c75facc93240c864bcbc9b45c492b32725ad2d4 > Author: Corentin Chary <[email protected]> > Date: Mon Nov 29 08:14:07 2010 +0100 > > eeepc-wmi: add rfkill support for wlan, bluetooth and 3g > > wimax support is missing because I don't have any DSDT > with WMI and wimax support. > > Most of the code comes from eeepc-laptop. > > Signed-off-by: Corentin Chary <[email protected]> > Signed-off-by: Matthew Garrett <[email protected]> > > commit 41eeea57adfb7d37b4a826877a8a6965cae5fb4a > Author: Corentin Chary <[email protected]> > Date: Mon Nov 29 08:14:06 2010 +0100 > > eeepc-wmi: add touchpad led support > > Most of the code comes from eeepc-laptop. > > Signed-off-by: Corentin Chary <[email protected]> > Signed-off-by: Matthew Garrett <[email protected]> > > commit 02846193f7b31e7f12a007894bdb1b4f4d7d6c22 > Author: Sreedhara DS <[email protected]> > Date: Fri Oct 22 15:43:55 2010 +0100 > > intel_scu_ipc: Utility driver for intel scu ipc > ... >
The following patch fixes the issue here (setup.log attached). - Sedat -
platform-x86-Kconfig-Replace-select-by-depends-on-ACPI_WMI.patch
Description: plain/text
setup.log
Description: Binary data
