On Thu, Dec 9, 2010 at 8:56 AM, Ike Panhc <[email protected]> wrote:
> Here are the enablement patches for hotkey events on ideapads and these 
> patches
> are made against current checkout of mainline kernel.
>
> After last time posting on LKML, there are several feedback and these patches
> are modified.
>
> From Dmitry Torokhov, using markup on functions to let the compiler knows 
> where
> to put and passing private variable instead of using global vairable. The

Great,

> acpi_handle is still a global variable becuase we need to pass handle pointer
> to rfk_set with its opcode but only one data argument available.

Of course there is only one data argument available, but since it's a
void *, you
can use a struct with your handle and the opcode :).

> From Dave Hansen, select INPUT_SPARSEKMAP to fill the dependency.
>
> These patches are available in the git repository at:
>  git://kernel.ubuntu.com/ikepanhc/ideapad-laptop.git ideapad-laptop
>
> Ike Panhc (7):
>  ideapad: add platform driver for ideapad
>  ideapad: let camera power control entry under platform driver

Maybe you could document that ? See
Documentation/ABI/testing/sysfs-platform-* files.

>  ideapad: add hotkey support
>  ideapad: select INPUT_SPARSEKMAP
>  ideapad: add markups, unify comments and return result when init
>  ideapad: pass ideapad_priv as argument (part 1)
>  ideapad: pass ideapad_priv as argument (part 2)
>
>  drivers/platform/x86/Kconfig          |    1 +
>  drivers/platform/x86/ideapad-laptop.c |  255 ++++++++++++++++++++++----------
>  2 files changed, 176 insertions(+), 80 deletions(-)


-- 
Corentin Chary
http://xf.iksaif.net
--
To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" 
in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to