On Fri, Jan 07, 2011 at 03:41:15PM +0800, Yin Kangkai wrote: > This driver implements an Extra ACPI EC driver for products based on Intel > Oaktrail platform. It is programming the EC space, through existing ACPI EC > driver, to provide user space layer the sysfs and rfkill interfaces to > enable/disable the Camera, Bluetooth, GPS, WiFi, 3G, and to show the status of > Touchscreen.
As far as I can tell, the only ACPI aspect of this driver is that it makes use of the ACPI EC driver? In that case I think the name's misleading. > @@ -0,0 +1,13 @@ > +What: /sys/devices/platform/intel_oaktrail/camera > +Date: Jan 2011 > +KernelVersion: 2.6.37 > +Contact: "Yin Kangkai" <[email protected]> > +Description: > + Control the camera. 1 means on, 0 means off. We really need a better approach for this kind of thing... > +What: /sys/devices/platform/intel_oaktrail/touchscreen > +Date: Jan 2011 > +KernelVersion: 2.6.37 > +Contact: "Yin Kangkai" <[email protected]> > +Description: > + Show the status of the touch screen. 1 means on, 0 means off. And this one, but we don't have one yet so I think this is ok. > + wwan_rfkill = oaktrail_rfkill_new("oaktrail-wwan", > + RFKILL_TYPE_WWAN, > + OT_EC_WWAN_MASK); Do you have any way to identify whether the hardware has all these features before registering? > +static struct dmi_system_id __initdata oaktrail_dmi_table[] = { > + { > + .ident = "OakTrail platform", > + .matches = { > + DMI_MATCH(DMI_PRODUCT_NAME, "OakTrail platform"), > + }, > + .callback = dmi_check_cb > + }, > + { } > +}; Is any hardware actually going to ship with this identifier, or will vendors change the string? -- Matthew Garrett | [email protected] -- To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
