On Mon, Jan 17, 2011 at 09:56:49AM -0800, Andy Ross wrote: > > > > + ipdev->input->dev.release = dev_noop_release; > > > > WTH is this??? > > It's an attempt to avoid this from drivers/base/core.c: > > WARN(1, KERN_ERR "Device '%s' does not have a release() " > "function, it is broken and must be fixed.\n", > dev_name(dev)); > > ...but it was in the wrong place. The input device doesn't hit that > path, the platform device does. Moved to where it belongs. >
It does not belong anywhere. Please create platform device dynamically (for example using platfrom_device_register_simple) and destroy it when done. The only time when static devices are [semi-]allowed (Greg has differing opioon on this I believe) is in platform/arch code for devices that can never be destroyed. Thanks. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
