On Sat, Feb 26, 2011 at 03:56:11PM +0300, Dan Carpenter wrote: > In the original code, if "device_enum" was NULL then it would > dereference it when it printed the error message.
Yup, this and the others are actual bugs, thanks for reviewing the code. > Signed-off-by: Dan Carpenter <[email protected]> > > diff --git a/drivers/platform/x86/sony-laptop.c > b/drivers/platform/x86/sony-laptop.c > index 0db9049..c24aa4a 100644 > --- a/drivers/platform/x86/sony-laptop.c > +++ b/drivers/platform/x86/sony-laptop.c > @@ -1311,7 +1311,11 @@ static void sony_nc_rfkill_setup(struct acpi_device > *device) > } > > device_enum = (union acpi_object *) buffer.pointer; > - if (!device_enum || device_enum->type != ACPI_TYPE_BUFFER) { > + if (!device_enum) { > + pr_err(DRV_PFX "Invalid SN06 return object."); Just a nitpick but I'd say there was no return object at all. ;) -- mattia :wq! -- To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
