On Thu, Mar 10, 2011 at 07:02:34PM +0800, Lee, Chun-Yi wrote:
> msi-laptop: use pr_<level> for messages
>
> Cc: Carlos Corbacho <[email protected]>
> Cc: Matthew Garrett <[email protected]>
> Cc: Dmitry Torokhov <[email protected]>
> Cc: Corentin Chary <[email protected]>
> Signed-off-by: Lee, Chun-Yi <[email protected]>
> ---
> drivers/platform/x86/msi-laptop.c | 13 ++++++-------
> 1 files changed, 6 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/platform/x86/msi-laptop.c
> b/drivers/platform/x86/msi-laptop.c
> index 028d2c6..77a6c3b 100644
> --- a/drivers/platform/x86/msi-laptop.c
> +++ b/drivers/platform/x86/msi-laptop.c
> @@ -445,8 +445,7 @@ static struct platform_device *msipf_device;
>
> static int dmi_check_cb(const struct dmi_system_id *id)
> {
> - printk(KERN_INFO "msi-laptop: Identified laptop model '%s'.\n",
> - id->ident);
> + pr_info("msi-laptop: Identified laptop model '%s'.\n", id->ident);
No, you need to add:
#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
at the very beginning of your driver (before includes) and then just do
pr_info("Identified laptop model '%s'.\n", id->ident);
and pr_fmt() will ensure that alll your messages use consistent prefix.
Thanks.
--
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe platform-driver-x86"
in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
