Hi Corentin, 於 一，2011-05-23 於 08:25 +0200，Corentin Chary 提到： > On Sun, May 22, 2011 at 2:02 AM, Joey Lee <[email protected]> wrote: > > 於 日，2011-05-22 於 00:43 +0100，Carlos Corbacho 提到： > >> On Sunday 22 May 2011 00:33:52 Lee, Chun-Yi wrote: > >> > That will be better to check the existence of internal 3G device when > >> > we set threeg capability and generate killswitch for threeg. It can > >> > avoid userland access 3G rfkill but the machine doesn't have internal > >> > 3G device. > >> > > >> > Reference: bko#32862 > >> > https://bugzilla.kernel.org/show_bug.cgi?id=32862 > >> > > >> > Tested on Acer Aspire 8930G, Acer Travelmate 8572 > >> > > >> > Tested-by: Hector Martin <[email protected]> > >> > >> Acked-by: Carlos Corbacho <[email protected]> > >> > >> If you can now autodetect 3G and already have the relevant rfkill device, > >> then > >> you should also rip out the remaining sysfs support for it as it's no > >> longer > >> necessary. > >> > >> -Carlos > > > > Got it! > > I will send another patch to remove threeg sysfs file. > > I'm not sure you can drop sysfs files like that, as it will break the ABI. >
Yes, you are right. > Could you document acer-wmi in > Documentation/ABI/testing/sysfs-platform-acer-wmi.txt ? > This allows to check when a sysfs file was added, who use it, etc... > > Thanks, > Thank's for your suggestion, I will maintain the ABI document like sysfs-platform-asus-wmi. But, when can I remove threeg sysfs file? Thank's Joey Lee -- To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
