Hi Matthew, 於 二,2011-05-31 於 14:20 +0800,Lee, Chun-Yi 提到: > Fix a bitwise bug that was found by Joern Heissler, it must be OR > but not AND when we query current device state. > > Acked-by: Joern Heissler <[email protected]> > Cc: Carlos Corbacho <[email protected]> > Cc: Matthew Garrett <[email protected]> > Cc: Dmitry Torokhov <[email protected]> > Cc: Corentin Chary <[email protected]> > Cc: Thomas Renninger <[email protected]> > Signed-off-by: Lee, Chun-Yi <[email protected]> > --- > drivers/platform/x86/acer-wmi.c | 6 +++--- > 1 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c > index 005417b..7d4675a 100644 > --- a/drivers/platform/x86/acer-wmi.c > +++ b/drivers/platform/x86/acer-wmi.c > @@ -1156,9 +1156,9 @@ static acpi_status wmid3_set_device_status(u32 value, > u16 device) > struct wmid3_gds_input_param params = { > .function_num = 0x1, > .hotkey_number = 0x01, > - .devices = ACER_WMID3_GDS_WIRELESS & > - ACER_WMID3_GDS_THREEG & > - ACER_WMID3_GDS_WIMAX & > + .devices = ACER_WMID3_GDS_WIRELESS | > + ACER_WMID3_GDS_THREEG | > + ACER_WMID3_GDS_WIMAX | > ACER_WMID3_GDS_BLUETOOTH, > }; > struct acpi_buffer input = {
Sorry for my mistake!! There have a bitwise bug in commit 6d88ff0f8ef3529f68233d3963b2a7e07f8e4f69 in kernel 3.0-rc1. Please kindly help to review and merge this patch to 3.0-rc2 to fix it. Thank's a lot! Joey Lee -- To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
