On Thu, Jun 02, 2011 at 09:30:56AM +0800, AceLan Kao wrote: > Mattew, > > Dell tells us that they will use the same touchpad chip for their products, > with the same touchpad LED layout, so I place the code in the dell-laptop.
Forever? I don't believe it's possible for Dell to guarantee that. The command sequenece is sent to the touchpad, so it needs to go in the touchpad driver. > And F22 already map to enable/disable touchpad in X, BIOS and synaptics driver > do nothing for this event, and my code only turns on/off the touchpad LED, > not enable/disable the touchpad. If this were to be done in kernel then it should be via a notifier chain to the touchpad driver, but I suspect that you'd still get pushback on that. It's better to leave this kind of thing to userland. > BIOS should manage this kind of action to enable/disable touchpad and > the LED, but Dell doesn't want to modify their BIOS to do that, since > the touchpad driver of MS Windows manages to enable/disable touchpad > and the LED by themselves, so Linux should do the same thing as > Windows does. > > That's why we need those code and why I think dell-laptop is a good > place for them. I'm afraid not. dell-laptop only contains code that speaks to dell-specific hardware. It seems likely that this command sequence performs LED control via the touchpad rather than via any dell-specific mechanism, so the code needs to go in the touchpad driver. -- Matthew Garrett | [email protected] -- To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
