Hi Greg On Fri, Sep 2, 2011 at 12:50 AM, <[email protected]> wrote: > samsung_init() should not return success if not all devices are initialized. > Otherwise, samsung_exit() will dereference sdev NULL pointers and others. > > Signed-off-by: David Herrmann <[email protected]> > Cc: stable <[email protected]> > Signed-off-by: Greg Kroah-Hartman <[email protected]> > --- > drivers/platform/x86/samsung-laptop.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > --- a/drivers/platform/x86/samsung-laptop.c > +++ b/drivers/platform/x86/samsung-laptop.c > @@ -799,7 +799,7 @@ static int __init samsung_init(void) > sabi_iface = ioremap_nocache(ifaceP, 16); > if (!sabi_iface) { > pr_err("Can't remap %x\n", ifaceP); > - goto exit; > + goto error_no_signature; > } > if (debug) { > printk(KERN_DEBUG "ifaceP = 0x%08x\n", ifaceP); > @@ -851,7 +851,6 @@ static int __init samsung_init(void) > if (retval) > goto error_file_create; > > -exit: > return 0; > > error_file_create: > > >
"From: " line is missing in this patch and several others of this series. "git am" applies them with an email only so Matthew needs to fix them when applying them or you could just resend them with git-format-patch? Thanks and regards David -- To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
