On Tue, Mar 20, 2012 at 5:05 PM, Matthew Garrett <[email protected]> wrote: > On Tue, Mar 20, 2012 at 09:53:01AM +0100, Corentin Chary wrote: >> From: Corentin Chary <[email protected]> >> >> On these laptops, the ACPI video is not functional, and very unlikely >> to be fixed by the vendor. Note that intel_backlight works for some >> of these laptops, and the backlight from samsung-laptop always work. >> >> The good news is that newer laptops have functional ACPI video device >> and won't end up growing this list. > > Are the hotkeys delivered via ACPI or via the Samsung device? If the > latter, you can just do unregister_acpi_video() instead in the samsung > driver and avoid having more machine-specific quirks in the ACPi code.
I wasn't aware of acpi_video_unregister(). The issue with that solution is that it makes it harder to respect acpi_video= parameter. On these machines, the ACPI Video device is broken (I don't know how, I don't have the hardware, I just know it doesn't work at all), and I want the default to be acpi_backlight=vendor, but it is still a good idea to let users force acpi_backlight=video. But if the policy is to use acpi_video_unregister() when the video module is known to be broken, let's do that. -- Corentin Chary http://xf.iksaif.net -- To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
