On Sat, 23 Jun 2012, Joe Perches wrote: > On Sat, 2012-06-23 at 21:40 -0300, Henrique de Moraes Holschuh wrote: > > On Sun, 17 Jun 2012, Joe Perches wrote: > > > Use a more current logging style. > > > > > > Add #define DEBUG and use pr_debug to enable dynamic debugging. > > > Coalesce formats and align arguments. > > > > > > Signed-off-by: Joe Perches <[email protected]> > > > > Joe, are there any extra procedures required from the user to get the debug > > messages with this patch applied? > > No. > > The added #define DEBUG makes dynamic_debug emit those > messages automatically. Without the #define DEBUG, then
I suspected as much, but I wanted direct confirmation. That #define DEBUG is a relatively recent enhancement to dynamic printk, isn't it? Something I will have to keep in mind if I resume doing backports of this driver for 2.6.32, 3.0 and 3.2 ? > these tp_[v]dbg calls might not be compiled in at all. > > These to_[v]dbg calls can be turned off via the normal > dyn_debug mechanisms. > > see: Documentation/dynamic-debug-howto.txt Ok. That's good enough for me. Acked-by: Henrique de Moraes Holschuh <[email protected]> -- "One disk to rule them all, One disk to find them. One disk to bring them all and in the darkness grind them. In the Land of Redmond where the shadows lie." -- The Silicon Valley Tarot Henrique Holschuh -- To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
