On Wed, 2014-01-15 at 14:29 +0800, Alex Hung wrote:
This looks pretty good, but:
> +static void hpwl_notify(struct acpi_device *acpi_dev, u32 event)
> +{
> + const struct key_entry *key;
> +
> + if (event != 0x80) {
> + pr_info("Received unknown event (0x%x)\n", event);
> + return;
> + }
You're checking that it's 0x80, then using
sparse_keymap_entry_from_scancode() to effectively check whether it's
0x80, so this is redundant. But I suspect that this is actually wrong -
0x80 is often used as a generic notification event, with a separate
method for looking up the actual keycode. Do you have some ASL
describing the device?
Also, could you add a description of what the device does to the commit
so it shows up nicely in the changelog?
--
Matthew Garrett <[email protected]>
N�����r��y����b�X��ǧv�^�){.n�+�����_����+ޯ :�{ay� ʇڙ�,j��f���h���z� �w���
���j:+v���w�j�m��������zZ+�����ݢj"��!�i
