In store_sys_acpi, if count equals zero, or parse_arg()s sscanf call fails, 'value' remains possibly uninitialized. In that case 'value' shouldn't be used to produce the store_sys_acpi()s return value.
Only test the return value of set_acpi() if we can actually call it. Return rv otherwise. Signed-off-by: Frans Klaver <[email protected]> --- drivers/platform/x86/eeepc-laptop.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/platform/x86/eeepc-laptop.c b/drivers/platform/x86/eeepc-laptop.c index bd533c2..41f12ba 100644 --- a/drivers/platform/x86/eeepc-laptop.c +++ b/drivers/platform/x86/eeepc-laptop.c @@ -279,10 +279,10 @@ static ssize_t store_sys_acpi(struct device *dev, int cm, int rv, value; rv = parse_arg(buf, count, &value); - if (rv > 0) - value = set_acpi(eeepc, cm, value); - if (value < 0) - return -EIO; + if (rv > 0) { + if (set_acpi(eeepc, cm, value) < 0) + return -EIO; + } return rv; } -- 2.1.0 -- To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
