On Thu, Sep 11, 2014 at 03:37:39PM -0700, Darren Hart wrote: > On Wed, Sep 10, 2014 at 10:05:20PM +0200, Paul Bolle wrote: > > parse_arg() has three possible return values: > > -EINVAL if sscanf(), in short, fails; > > zero if "count" is zero; and > > "count" in all other cases > > > > But "count" will never be zero. See, parse_arg() is called by the > > various store functions. And the callchain of these functions starts > > with sysfs_kf_write(). And that function checks for a zero "count". So > > we can stop checking for a zero "count", drop the "count" argument > > entirely, and transform parse_arg() into a function that returns zero on > > success or a negative error. That, in turn, allows to make those store > > functions just return "count" on success. The net effect is that the > > code becomes a bit easier to understand. > > > > While we're at it, let store_sys_acpi() return whatever error set_acpi() > > returns instead of remapping it to EIO. > > > > A nice side effect is that this GCC warning is silenced too: > > drivers/platform/x86/eeepc-laptop.c: In function ‘store_sys_acpi’: > > drivers/platform/x86/eeepc-laptop.c:279:10: warning: ‘value’ may be > > used uninitialized in this function [-Wmaybe-uninitialized] > > int rv, value; > > > > Which is, of course, the reason to have a look at parse_arg(). > > > > Signed-off-by: Paul Bolle <[email protected]> > > Queued, thanks Paul.
After discussion with Linus, I have had to drop this patch from the queue. We need to restore the -EIO error code mapping to store_sys_acpi(). Apologies for the run around here, we had to define some policy around this. -- Darren Hart Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
