Darren Hart <[email protected]> writes: >> +static DEVICE_ATTR(simplecmd, S_IWUSR | S_IRUSR, >> + NULL, >> + intel_pmc_ipc_simple_cmd_store); >> +static DEVICE_ATTR(northpeak, S_IWUSR | S_IRUSR, >> + NULL, >> + intel_pmc_ipc_northpeak_store); >> + >> +static struct attribute *intel_ipc_attrs[] = { >> + &dev_attr_northpeak.attr, >> + &dev_attr_simplecmd.attr, >> + NULL >> +}; > > > Please use the DEVICE_ATTR_RW macro.
Minor nit-nit: Those attributes don't have any "show" function so you cannot use DEVICE_ATTR_RW. If they really are not intended to be readable, then the DEVICE_ATTR_WO macro could be used for that. Bjørn -- To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
