On Wednesday 10 June 2015 15:01:19 Hans de Goede wrote: > Port the backlight selection logic to the new backlight interface > selection API. > > Signed-off-by: Hans de Goede <[email protected]> > --- > drivers/platform/x86/dell-laptop.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/platform/x86/dell-laptop.c > b/drivers/platform/x86/dell-laptop.c > index d688d80..db2e031 100644 > --- a/drivers/platform/x86/dell-laptop.c > +++ b/drivers/platform/x86/dell-laptop.c > @@ -31,6 +31,7 @@ > #include <linux/slab.h> > #include <linux/debugfs.h> > #include <linux/seq_file.h> > +#include <acpi/video.h> > #include "../../firmware/dcdbas.h" > > #define BRIGHTNESS_TOKEN 0x7d > @@ -1921,10 +1922,7 @@ static int __init dell_init(void) > &dell_debugfs_fops); > > #ifdef CONFIG_ACPI > - /* In the event of an ACPI backlight being available, don't > - * register the platform controller. > - */ > - if (acpi_video_backlight_support()) > + if (acpi_video_get_backlight_type() != acpi_backlight_vendor) > return 0; > #endif >
Now I'm thinking... Is this correct condition? And do we need it? This Dell backlight interface works even if ACPI or intel i915 driver controls backlight. Why we should prevent dell-laptop.ko to register Dell backlight interface if ACPI video already register one? And why not prevent when intel i915 driver register another? -- Pali Rohár [email protected] -- To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
