On Fri, Nov 20, 2015 at 4:41 PM, Pali Rohár <[email protected]> wrote: > On Saturday 21 November 2015 01:29:04 Darren Hart wrote: >> Pali, was this something you wanted to discuss more before I merge >> it? > > Just one note: > >> + if (keycode == 0) { > > What about using define KEY_RESERVED instead hardcoded constant 0? > >> + pr_info("firmware scancode %d maps to unrecognized >> keycode %d\n", bios_entry->keycode, bios_entry->scancode); >> + continue; >> + } >
That would work, but only because KEY_RESERVED == 0. Let me send a better patch. --Andy -- To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
