Revision: 7408
          http://playerstage.svn.sourceforge.net/playerstage/?rev=7408&view=rev
Author:   gerkey
Date:     2009-03-10 00:42:19 +0000 (Tue, 10 Mar 2009)

Log Message:
-----------
Fixed race condition in gazebo's accessing shared memory segment

Modified Paths:
--------------
    code/branches/federation/gazebo/server/World.cc

Modified: code/branches/federation/gazebo/server/World.cc
===================================================================
--- code/branches/federation/gazebo/server/World.cc     2009-03-09 22:58:04 UTC 
(rev 7407)
+++ code/branches/federation/gazebo/server/World.cc     2009-03-10 00:42:19 UTC 
(rev 7408)
@@ -549,11 +549,14 @@
   //TODO: Move this method to simulator? Hard because of the models
   this->simIface->Lock(1);
 
+  /* This call releases our lock, which can lead to hard-to-track-down
+   * synchronization bugs.  Besides, it's a small optimization at best
   if (this->simIface->GetOpenCount() <= 0)
   {
     this->simIface->Unlock();
     return;
   }
+  */
 
   response = this->simIface->data->responses;
 


This was sent by the SourceForge.net collaborative development platform, the 
world's largest Open Source development site.

------------------------------------------------------------------------------
_______________________________________________
Playerstage-commit mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/playerstage-commit

Reply via email to