Author: glen Date: Tue Aug 31 17:26:04 2010 GMT Module: packages Tag: HEAD ---- Log message: - avoid duplicate even fire, i.e chrome got events twice
---- Files affected: packages/roundcube-plugins: roundcube-plugins.spec (1.7 -> 1.8) , keyboard_shortcuts-avoid-duplicate-event.patch (NONE -> 1.1) (NEW) ---- Diffs: ================================================================ Index: packages/roundcube-plugins/roundcube-plugins.spec diff -u packages/roundcube-plugins/roundcube-plugins.spec:1.7 packages/roundcube-plugins/roundcube-plugins.spec:1.8 --- packages/roundcube-plugins/roundcube-plugins.spec:1.7 Tue Aug 31 19:24:12 2010 +++ packages/roundcube-plugins/roundcube-plugins.spec Tue Aug 31 19:25:59 2010 @@ -5,7 +5,7 @@ Name: roundcube-plugins Version: 0.2 # DO NOT DECREASE RELEASE, subpackages will suffer -Release: 1.5 +Release: 2 License: GPL v2 Group: Applications/WWW Source0: http://roundcube-plugins.googlecode.com/files/jqueryui-1.8.2.1.tgz @@ -116,6 +116,9 @@ All persons listed below can be reached at <cvs_login>@pld-linux.org $Log$ +Revision 1.8 2010/08/31 17:25:59 glen +- avoid duplicate even fire, i.e chrome got events twice + Revision 1.7 2010/08/31 17:24:12 glen - roundcube >= 0.4 only ================================================================ Index: packages/roundcube-plugins/keyboard_shortcuts-avoid-duplicate-event.patch diff -u /dev/null packages/roundcube-plugins/keyboard_shortcuts-avoid-duplicate-event.patch:1.1 --- /dev/null Tue Aug 31 19:26:04 2010 +++ packages/roundcube-plugins/keyboard_shortcuts-avoid-duplicate-event.patch Tue Aug 31 19:25:59 2010 @@ -0,0 +1,28 @@ +--- keyboard_shortcuts/keyboard_shortcuts.js~ 2010-08-31 20:23:35.389211360 +0300 ++++ keyboard_shortcuts/keyboard_shortcuts.js 2010-08-31 20:22:05.000000000 +0300 +@@ -26,13 +26,18 @@ + rcmail.env.keyboard_shortcuts = true; + }); + +- $('body').keypress(function (e) { // IE +- key_pressed(e); +- }); +- +- $(document).keypress(function (e) { // Firefox +- key_pressed(e); +- }); ++ // do only one event handler, to avoid duplicate event fire ++ // rather dangerous if the event is fired twice for delete hotkey. ++ if ($.browser.msie) { ++ $('body').keypress(function (e) { ++ key_pressed(e); ++ }); ++ } else { ++ // the rest of the world ++ $(document).keypress(function (e) { ++ key_pressed(e); ++ }); ++ } + + function key_pressed (e) { + if (!rcmail.env.keyboard_shortcuts || rcmail.env.action == 'compose' || rcmail.env.task == 'login' || e.ctrlKey) ================================================================ ---- CVS-web: http://cvs.pld-linux.org/cgi-bin/cvsweb.cgi/packages/roundcube-plugins/roundcube-plugins.spec?r1=1.7&r2=1.8&f=u _______________________________________________ pld-cvs-commit mailing list [email protected] http://lists.pld-linux.org/mailman/listinfo/pld-cvs-commit
