On Tuesday 07 November 2006 21:46, [EMAIL PROTECTED] wrote:
> > > cat > pld-module.patch <<'EOF'
> >
> > perhaps name it with .sh extension?
>
> I knew pld-module.patch won't be the best name just after it came to my
> mind, changed.
just another idea, could use optional <<EOF for "patching section"

%build_kernel_module -m foo <<EOF
some scripting around here
EOF

something similar that %banner does.

hint: 'cat somescript.sh | sh' invokes 'somescript.sh'

> What I don't understand is why %{error: blabla} does not stop building,
> it's just displayed at the beginning.

i once asked the same from jbj, he replied me with a patch. i didn't apply it 
that time. but the similar patch is taken (attached) from openpkg.

oh, and don't use %Opts, it could conflict with spec macros. 
(hint: %__build_kernel_module_opts)

-- 
glen
+---------------------------------------------------------------------------
| Make sure that an %{error:<msg>} macro really stops further
| processing. Else it would be nothing more than a %{warn:<msg>}.
+---------------------------------------------------------------------------
Index: rpmio/macro.c
--- rpmio/macro.c	15 May 2003 13:42:01 -0000	1.1.1.7
+++ rpmio/macro.c	22 Jan 2004 21:42:32 -0000	1.2
@@ -1329,7 +1337,7 @@
 	    STREQ("error", f, fn)) {
 		int waserror = 0;
 		if (STREQ("error", f, fn))
-			waserror = 1;
+			waserror = 1, rc = 1;
 		if (g < ge)
 			doOutput(mb, waserror, g, gn);
 		else

_______________________________________________
pld-devel-en mailing list
[email protected]
http://lists.pld-linux.org/mailman/listinfo/pld-devel-en

Reply via email to