Caleb Maclennan wrote:
> Hello all,

Hi Caleb,

Just few hot comments on your spec:

> BuildRoot:    %{tmpdir}/%{name}-%{version}-root-%(id -u -n)
> Patch0:               %{name}-makefile.patch
> Patch1:               %{name}-desktop.patch

We try to keep the BuildRoot entry as the last in this section. Patch# just
after Sources.

> %files
> %dir %{_datadir}/lyricue

maybe just %{_datadir}/lyricue instead of 2 %files entries?

> %lang(en_US) %dir %{_datadir}/locale/en_US
> %lang(en_US) %dir %{_datadir}/locale/en_US/LC_MESSAGES
> %lang(en_US) %{_datadir}/locale/en_US/LC_MESSAGES/

Is this really different from the default "C" ? If no -> /dev/null

> %lang(es_ES) %dir %{_datadir}/locale/es_ES
> %lang(es_ES) %dir %{_datadir}/locale/es_ES/LC_MESSAGES
> %lang(es_ES) %{_datadir}/locale/es_ES/LC_MESSAGES/

mv $RPM_BUILD_ROOT%{_datadir}/locale/es{_ES,} in %install

> %lang(de) %dir %{_datadir}/locale/de
> %lang(sv) %{_datadir}/locale/sv/LC_MESSAGES/

... and use %find_lang in %install + %files -l ... instead of all this stuff. 
Except making %files shorter, it also allows to avoid packaging of "empty"
translation files (if any).

> %attr(755,root,root) %{_bindir}/lyricue
> %attr(755,root,root) %{_bindir}/lyricue_server
> %attr(755,root,root) %{_bindir}/lyricue_remote
> %attr(755,root,root) %{_bindir}/import_media

Is there anything in the package that should _not_ be packaged?
Maybe %{_bindir}/* instead?

  Andrzej M. Krzysztofowicz                  [EMAIL PROTECTED]
  phone (48)(58) 347 19 36
Faculty of Applied Phys. & Math.,   Gdansk University of Technology
pld-devel-en mailing list

Reply via email to