On Sun, Apr 18, 2010 at 09:04:01PM +0200, Przemyslaw Iskra wrote:
> On Sun, Apr 18, 2010 at 07:18:16PM +0200, Jacek Konieczny wrote:
> > On Sun, Apr 18, 2010 at 07:10:19PM +0200, sparky wrote:
> >
> > fastjar? Why fastjar and not java-sun-tools, icedtea6-jar or any other
> > jar?
>
> yup, this is wrong, any jar will do
Fixed.
> > lsb-release? it builds without it…
>
> But distribution identificator is more correct, I think.
That is good.
> > > - dropped BR: wget
> > > + WGET=%{_bindir}/wget \
>
> It is, there is nothing that checks for executability or file existance.
Maybe WGET=/bin/false would be even better? Will not silently allow to
download files during build?
Of course, that would break things if that $WGET is embeded somewhere in
the built package…
Let's keep it the way it is now. Good enough, I guess.
Greets,
Jacek
_______________________________________________
pld-devel-en mailing list
[email protected]
http://lists.pld-linux.org/mailman/listinfo/pld-devel-en
