click-bait commit message detected.

better commit message would be that describes commit without having to click (or other means to see diff) to figure out what commit is about.


sane is ambiguous:

1. it's also a product: SANE - Scanner Access Now Easy

2. sane in what way, what was not "sane" in earlier version?


better ones:

- use requires_eq instead of requires_releq

- omit release matching from ghc dependencies

- ...



On 5/24/20 1:32 AM, baggins wrote:

commit f36b2a4f08925aaaf204991b91f742f29e1cbad6
Author: Jan Rękorajski <bagg...@pld-linux.org>
Date:   Sun May 24 00:31:52 2020 +0200

     - sane deps

  ghc-package.spec | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
---
diff --git a/ghc-package.spec b/ghc-package.spec
index 501c6f9..ee96b06 100644
--- a/ghc-package.spec
+++ b/ghc-package.spec
@@ -20,7 +20,7 @@ BuildRequires:        ghc-prof
  #BuildRequires:       ghc-OTHERMODULE-prof
  %endif
  BuildRequires:        rpmbuild(macros) >= 1.608
-%requires_releq        ghc
+%requires_eq   ghc
  Requires(post,postun):        /usr/bin/ghc-pkg
  #Requires:    ghc-OTHERMODULE
  BuildRoot:    %{tmpdir}/%{name}-%{version}-root-%(id -u -n)

_______________________________________________
pld-devel-en mailing list
pld-devel-en@lists.pld-linux.org
http://lists.pld-linux.org/mailman/listinfo/pld-devel-en

Reply via email to