W dniu 12.04.2021 o 21:53, Arkadiusz Miśkiewicz pisze:
> W dniu 12.04.2021 o 21:20, Peri Noid pisze:
>> Dnia poniedziałek, 12 kwietnia 2021 20:56:49 CEST Arkadiusz Miśkiewicz pisze:
>> [...]
>>> Should we change our default rpm macro?
>>>
>>> $ rpm --showrc|grep CMAKE_BUILD_TYPE
>>> -DCMAKE_BUILD_TYPE=%{!?debug:PLD}%{?debug:Debug} \
>>
>> Yes please! Make it either conditional or "the opposite". I couldn't compile
>> kile recently just becouse of this since I didn't understand the source of
>> the
>> problem.
>>
>
> I have no idea why we use PLD there.
Probably to avoid default release optimizations that cmake adds (because
we use our own CFLAGS etc).
>
> commit 547ff09556739ab0f98239b1278dddf9b506ff4e
> Author: Kacper Kornet <drae...@pld-linux.org>
> Date: Thu Feb 3 16:38:26 2011 +0000
>
> - use our own build type in cmake
>
> Changed files:
> rpm.macros -> 1.604
>
> diff --git a/rpm.macros b/rpm.macros
> index 8537d8a..c04033a 100644
> --- a/rpm.macros
> +++ b/rpm.macros
> @@ -245,23 +245,21 @@
> %{?__cc:CC="%{__cc}"} \\\
> %{?__cxx:CXX="%{__cxx}"} \\\
> CPPFLAGS="${CPPFLAGS:-%{rpmcppflags}}" \\\
> -CFLAGS="${CFLAGS:-%{rpmcflags}}" \\\
> -FFLAGS="${FFLAGS:-%{rpmcflags}}" \\\
> -FCFLAGS="${FCFLAGS:-%{rpmcflags}}" \\\
> -CXXFLAGS="${CXXFLAGS:-%{rpmcxxflags}}" \\\
> -LDFLAGS="${LDFLAGS:-%{rpmldflags}}" \\\
> %{__cmake} \\\
> -DCMAKE_VERBOSE_MAKEFILE=ON \\\
> - -DCMAKE_BUILD_TYPE=%{!?debug:Release}%{?debug:Debug} \\\
> + -DCMAKE_BUILD_TYPE=%{!?debug:PLD}%{?debug:Debug} \\\
>
--
Arkadiusz Miśkiewicz, arekm / ( maven.pl | pld-linux.org )
_______________________________________________
pld-devel-en mailing list
pld-devel-en@lists.pld-linux.org
http://lists.pld-linux.org/mailman/listinfo/pld-devel-en
