http://plf.zarb.org/bugzilla/show_bug.cgi?id=178
--- Comment #2 from Richard Neill <[EMAIL PROTECTED]> 2007-12-06 13:24:59 CEST
---
Thanks. Yes, this now works for me.
However, I think there's an implicit bug in the file
/usr/sbin/download-flash-player-plugin, in that the md5sum of a the plugin
installer is hardcoded. This will *certainly* break again.
May I suggest the following improvements:
1)The test near the start of the script for [ -e $TARBALLDIR/$FILENAME]
means that "urpmi flash-player-plugin" will fail for anyone who has already
been bitten by this bug. The previously downloaded file (with the md5 mismatch)
will still be on the system, and will require manual intervention to remove.
2)Remove the message "Error: Unable to download. Possibly a network problem or
an obsolete package"
and replace it with 2 distinct error messages:
2.a)Test the return value of curl, and print.
"Error: unable to download from "$URL". Possibly a network problem, or an
obsolete package"
2.b)Test the md5sum check, and print
"Error: downloaded file "$TARBALLDIR/$FILENAME" fails the md5sum check.
Possibly it has been corrupted; alternatively the file on the server has been
updated more recently than this script"
3)Consider some way to keep the md5sum in sync with the file?
As it is, the install is fine for a Linux expert, but for someone who uses
rpmdrake at the GUI, it will cause incomprehensible breakage.
--
Configure bugmail: http://plf.zarb.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
_______________________________________________
PLF-discuss mailing list
[email protected]
https://www.zarb.org/mailman/listinfo/plf-discuss
