Zombie Ryushu wrote:
> Name        : hhexen                       Relocations: (not relocatable)
> Version     : 1.6.0                             Vendor: Penguin Liberation 
> Front
> Release     : 1plf2010.0                    Build Date: ven. 14 ao?t 2009 
> 06:52:41 CEST
> Install Date: (not installed)               Build Host: 
> cooker64.home.nanardon.zarb.org
> Group       : Amusements/Games/Action/Shoot   Source RPM: (none)

Invalid group, see Mandriva group list.

> Size        : 6773649                          License: GPL

Non-specific license tag, see Mandriva licenses policy.

> Signature   : (none)
> Packager    : Zombie Ryushu <[email protected]>
> URL         : http://hhexen.sourceforge.net/
> Summary     : Hacked Hexen is a Linux port of Raven Games old shooter, Hexen
> Description :
> Hacked Hexen is a Linux port of Raven Game's old shooter, Hexen.
> 
> This is a new release of Dan's excellent Hacked Hexen, by the
> authors of Hammer of Thyrion (Hexen II). We're applying fixes,
> adding a few features, and ensuring it runs on most *nix operating
> systems.
> 
> This package contains the OpenGL enabled binary.
> 
> This package is PLF because it requires non-free data.

Not a valid reason. This belongs to contrib or mdv non-free. Please
submit it there instead.

> Toni Graffy <[email protected]> - 1.5.3-0.pm.1:
> - update to 1.5.3

Changelog is missing.

> # Copyright (c) 2008-2009 oc2pus
> # This file and all modifications and additions to the pristine
> # package are under the same license as the package itself.
> #
> # Please submit bugfixes or comments to [email protected]
> 
> # norootforbuild

opensuse flag, unneeded in mandriva .specs.

> %define _prefix       /usr

Does not make sense.

> %define distsuffix    plf
> 
> Name:                 hhexen
> Summary:              Hacked Hexen is a Linux port of Raven Games old 
> shooter, Hexen
[...]
> Vendor:         Penguin Liberation Front
> Packager:       Zombie Ryushu <[email protected]>

Disallowed by Mandriva policy. Remove them.

> URL:                  http://hhexen.sourceforge.net/
> Source:                       
> http://downloads.sourceforge.net/hhexen/%{name}-%{version}-src.tgz
> Source1:              %{name}.png
> Source2:              
> http://downloads.sourceforge.net/hhexen/hexen_demo_wad_1.1.tgz
> Source90:             %{name}-rpmlintrc
> BuildRoot:            %{_tmppath}/%{name}-%{version}-build
> BuildRequires:        GL-devel
> BuildRequires:        SDL-devel >= 1.2.4
> BuildRequires:        SDL_mixer-devel >= 1.2.4
> Requires:     timidity

No package provides "timidity". Did you test this package at all?

[...]
> %__make %{?jobs:-j%{jobs}}

Use %make.


> # compile the software version (hhexen-sdl)
> %__make clean
> %configure \
>       --disable-gl \
>       --with-audio=sdlmixer
> %__make %{?jobs:-j%{jobs}}

Same here.

Also, are both versions really needed (hhexen-sdl and gl)?

> %install
> # wrapper startscript
> %__install -dm 755 %{buildroot}%{_bindir}
> for i in gl sdl; do
>       %{__cat} > %{name}-$i.sh << EOF
> #!/bin/bash
> if [ ! -f \$HOME/.hhexen/version-%{version} ]; then
>       mkdir -p \$HOME/.hhexen
> 
>       # if demo is installed create a link
>       if [ -f %{_datadir}/games/%{name}/hexen.wad ]; then
>               cd \$HOME/.hhexen
>               ln -s %{_datadir}/games/%{name}/hexen.wad .
>       fi
>       touch version-%{version}
> fi
> cd \$HOME/.hhexen
> %{_prefix}/games/%{name}-$i "\$@"
> EOF
> 
>       %__install -m 755 %{name}-$i.sh \
>               %{buildroot}%{_bindir}
> done

These belong to %{_gamesbindir} instead of %{_bindir}.

> # install the gamedata
> %__install -dm 755 %{buildroot}/%{_datadir}/games/%{name}
> %__install -m 644 hexen.wad \
>       %{buildroot}%{_datadir}/games/%{name}

Use %_gamesdatadir.

> %__install -dm 755 %{buildroot}%{_prefix}/games/%{name}

This seems very wrong, you are creating a directory in our %_gamesbindir.

> %__install -dm 755 %{buildroot}%{_datadir}/pixmaps
> for i in gl sdl; do
>       # binaries
>       %__install -m 755 %{name}-$i \
>               %{buildroot}%{_prefix}/games
> 
>       # icon
>       %__install -m 644 %{SOURCE1} \
>               %{buildroot}%{_datadir}/pixmaps/%{name}-$i.png
> done
> 
> # install menu entry
> %__install -dm 755 %{buildroot}%{_datadir}/applications
> %{__cat} > %{name}-gl.desktop << EOF
> [Desktop Entry]
> Name=Hacked Hexen (OpenGL)
> GenericName=Hacked Hexen (OpenGL)
> Comment=Hacked Hexen is a Linux port of Raven Game's old shooter, Hexen
> Exec=%{name}-gl.sh
> Icon=%{name}-gl
> Terminal=false
> Type=Application
> #Encoding=UTF-8
> EOF

Remove Encoding=UTF-8 instead of commenting it.

[...]
> %__install -m 644 %{name}*.desktop \
>       %{buildroot}%{_datadir}/applications
> 

-- 
Anssi Hannula
_______________________________________________
PLF-discuss mailing list
[email protected]
https://www.zarb.org/mailman/listinfo/plf-discuss

Reply via email to