Zombie Ryushu wrote:
> Name        : darkplaces                   Relocations: (not relocatable)
> Version     : rev20080511                       Vendor: Penguin Liberation 
> Front
> Release     : 1plf2010.0                    Build Date: ven. 14 ao?t 2009 
> 10:48:24 CEST
> Install Date: (not installed)               Build Host: 
> cooker64.home.nanardon.zarb.org
> Group       : Amusements/Games/3D/Shoot     Source RPM: (none)

Invalid group.

[...]
> This package is in PLF because it requires non-free data.

Should probably be in Mandriva contrib (as d2x-xl) or non-free, then, as
this package itself is marked as GPLv2+.

> [email protected]:
> - Initial package based on a previous build
> - NOTE: I am the only one you should ask about
> -       THIS package! Do not email the others
> -       mentioned below!
> - Only build darkplaces without nexuiz

New changelog entry is missing.

darkplaces.spec:
> # norootforbuild

Opensuse flag.

[...]
> Vendor:         Penguin Liberation Front
> Packager:       Zombie Ryushu <[email protected]>

Should not be in .spec.

> # This is necessary as these libraries are loaded during runtime
> # and therefore it isn't picked up by RPM during build
> Requires:     zlib libvorbis libjpeg curl

This won't work correctly with biarch. Specify library packages using
%mklibname instead. Also, curl is not a library.

[...]
> %package server
> Group: Amusements/Games

This group is also wrong.

> Summary: Dedicated server for the darkplaces engine
> # This is necessary as these libraries are loaded during runtime
> # and therefore it isn't picked up by RPM during build
> Requires:     zlib curl

Same as above.

> Provides:     nexuiz-engine = 242
[...]
> %build
> %{__make} release OPTIM_RELEASE="$RPM_OPT_FLAGS"

Use %make instead of %__make; if it does not work, add a comment.

> %install
> 
> # Install the main programs
> %{__mkdir_p} %{buildroot}%{_bindir}
> %{__install} -m 0755 darkplaces-glx \
>         %{buildroot}%{_bindir}/darkplaces-glx
> %{__install} -m 0755 darkplaces-sdl \
>         %{buildroot}%{_bindir}/darkplaces-sdl

These should be in %{_gamesbindir}.

> %{__install} -m 0755 darkplaces-dedicated \
>         %{buildroot}%{_bindir}/darkplaces-dedicated
[...]

-- 
Anssi Hannula
_______________________________________________
PLF-discuss mailing list
[email protected]
https://www.zarb.org/mailman/listinfo/plf-discuss

Reply via email to