On 8/25/11 3:52 PM, Maurits van Rees wrote:
Hi,
Op 23-08-11 22:35, Karl Johan Kleist schreef:
It just occurred to me, that it's probably not very smart to use the get_fs()
helper function in restore_main(). We can probably not assume that the
filestorage file already exists. So I've restored the old code in
restore_main()
As you indicate here, this might need a bit more thinking, as now a
restore could place the filestorage in a wrong location.
Also, collective.recipe.filestorage offers more ways to name the
additional filestorages and I guess your current code only handles the
default location. Fair enough, really, but I wonder if we can do better.
Also, it occured to me that these additional filestorages may come with
their own blobstorages (oh joy...). That may need a bit of thinking too.
I haved moved your code to a new branch:
https://svn.plone.org/svn/collective/buildout/collective.recipe.backup/branches/kleist-recipe-filestorage
I have also reverted those changes on trunk.
Biggest reason is that this clears the way for merging back my long
overdue blobstorage backup support branch and do a release. We can work
on collective.recipe.filestorage later.
Thanks for your contribution.
FWIW, the in-house backup script that we use with
collective.recipe.filestorage reads zope.conf and/or zeo.conf to figure
out what storages exist and where they are. It's pretty dumb about the
parsing though; just some regexes.
David
----------
David Glick
Web Developer
[email protected]
206.286.1235x32
Online tools and strategies for the environmental movement.
Sign up for our newsletter: http://www.groundwire.org/email-capture
_______________________________________________
Product-Developers mailing list
[email protected]
https://lists.plone.org/mailman/listinfo/plone-product-developers
