Hi, >> Well, warnings I have seen from Visual C/C++ 6.0 (the ancient one) are >> mostly >> about longs being implicitly converted to ints and the like. Adding >> explicit casts >> may silence the compiler, but the code is not going to work better and >> certainly >> is not going to be more readable - in my opinion. I think we will need >> to be >> careful here. I vote yes to these issues: >> - remove unused variables (makes the code less confusing) >> - check the use of sprintf() (makes the code safer) >> - functions that do not return a value but should (makes the code safer too) >> >> I do not know enough about C99 to comment on deprecated features, but >> I would not like to see explicit casts all over the place. > > Werner, I think Arjen's suggestions are good ones about limiting the kind of > changes you do. Also, to make sure you are not introducing any new issues, > I suggest you start conservatively with a few sample changes, and let me > test them on Linux/gcc before you apply those same kind of changes to all > source files.
As you suggested I wanted to "solve" one major issue and propose the changes to the list - if all agree (i.e. nobody disagrees) I wanted to change all similar issues. And then the next major issue and so on.... But I'm working in the moment on other stuff (qhull, etc.) so this will have to wait a little. Thanks, Werner -- Dipl. Ing. Werner Smekal Institut fuer Allgemeine Physik Technische Universitaet Wien Wiedner Hauptstr 8-10 A-1040 Wien Austria email: [EMAIL PROTECTED] web: http://www.iap.tuwien.ac.at/~smekal phone: +43-(0)1-58801-13463 (office) +43-(0)1-58801-13469 (laboratory) fax: +43-(0)1-58801-13499 ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ Plplot-devel mailing list Plplot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/plplot-devel
