On 2006-12-04 22:32+0100 Werner Smekal wrote:
> Hi,
>
> in FindwxWidgets.cmake is a small bug regarding MinGW and MSys. From line 150
> on there is
>
> IF(WIN32)
> SET(WIN32_STYLE_FIND 1)
> ENDIF(WIN32)
> IF(MINGW)
> SET(WIN32_STYLE_FIND 0)
> SET(UNIX_STYLE_FIND 1)
> ENDIF(MINGW)
> IF(UNIX)
> SET(UNIX_STYLE_FIND 1)
> ENDIF(UNIX)
>
> Problem here is that pure MinGW in Windows CLI ("MinGW Makefiles" Generator)
> needs WIN32_STYLE not UNIX_STYLE, since there is no wx-config in that case.
> Since from CMake 2.4.4 on (just read in the changelog) MSYS is defined for
> the MSys case, that bug is easy to fix,
>
> IF(MSYS)
> SET(WIN32_STYLE_FIND 0)
> SET(UNIX_STYLE_FIND 1)
> ENDIF(MSYS)
>
> and if I think about it, there is also a bug for cygwin, since here WIN32 and
> UNIX is 1, so both WIN32_STYLE_FIND and UNIX_STYLE_FIND would be 1 than, so
> to fix also that case we would need
>
> IF(WIN32)
> SET(WIN32_STYLE_FIND 1)
> ENDIF(WIN32)
> IF(MSYS OR UNIX)
> SET(WIN32_STYLE_FIND 0)
> SET(UNIX_STYLE_FIND 1)
> ENDIF(MSYS OR UNIX)
>
Hi Werner (off CMake list and put on to the PLplot list since my comment
is mostly relevant to PLplot):
Thanks for dealing with this issue.
I suggest you simply copy your changed FindwxWidgets.cmake to the PLplot
cmake/modules directory and commit it. For all the PLplot cvs users now,
and for our next PLplot release, your changed version will take precedence
over the cmake one so we will all get to test it without having to apply
cmake patches.
Once you are happy with the PLplot version of this module for all your
windows platforms (and the rest of us have tested it as well to make sure it
doesn't cause problems on our platforms), then I think you should just go
ahead and send in a CMake bug report with your patch (along with comments
about exactly what platforms we have all tested). Once your patch gets
accepted by the cmake developers and included in an official release (2.4.5
was just released so that next release may be many months from now), then we
can remove the PLplot version of FindwxWidgets.cmake and bump the minimum
accepted version of cmake for PLplot to the version that includes your fix.
Alan
__________________________
Alan W. Irwin
Astronomical research affiliation with Department of Physics and Astronomy,
University of Victoria (astrowww.phys.uvic.ca).
Programming affiliations with the FreeEOS equation-of-state implementation
for stellar interiors (freeeos.sf.net); PLplot scientific plotting software
package (plplot.org); the Yorick front-end to PLplot (yplot.sf.net); the
Loads of Linux Links project (loll.sf.net); and the Linux Brochure Project
(lbproject.sf.net).
__________________________
Linux-powered Science
__________________________
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Plplot-devel mailing list
Plplot-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/plplot-devel
