On 2008-02-08 09:34-0800 Alan W. Irwin wrote:
> Thanks, Werner. Please bring up this issue again after the release if I
> forget to do it myself.
Hi Werner:
Since nobody argued against this and you argued well for it, I have just
reinstated your change.
I wanted to delay this until after the release because I was concerned about
the implementation; CMake handles -DLIB_TAG:STRING=whatever differently
than -DLIB_TAG=whatever. (It puts the typed version in the cache and just
sets an ordinary variable when it is not typed.) However, some simple tests
I have done seem to indicate that your implementation with the simple
set(LIB_TAG "${LIB_TAG}d")
does the right thing whether the -D option is typed or not (probably because
this set command only sets the ordinary CMake variable and not the cached
version).
The handling of untyped -D options will be changed for CMake 2.6.x (I think
they will be put into the cache just like typed variables) so we may have to
revisit this, but the implementation should be fine for now and should give
the same results for untyped and typed setting of LIB_TAG with a -D
option.
Alan
__________________________
Alan W. Irwin
Astronomical research affiliation with Department of Physics and Astronomy,
University of Victoria (astrowww.phys.uvic.ca).
Programming affiliations with the FreeEOS equation-of-state implementation
for stellar interiors (freeeos.sf.net); PLplot scientific plotting software
package (plplot.org); the libLASi project (unifont.org/lasi); the Loads of
Linux Links project (loll.sf.net); and the Linux Brochure Project
(lbproject.sf.net).
__________________________
Linux-powered Science
__________________________
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Plplot-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/plplot-devel
