Hi Jerry:

I noticed some garbage after the device name for the Ada thick and thin
example 31 results in stderr.  In contrast to this less-than-ideal result
for plgfnam, plgver produces good looking results for Ada thick and thin
example 1 library version.  There plgver is called using the functional form
without arguments so I tried to do the same for plgfnam and it didn't work.

IMO, plgdev, plgfnam, and plgver (and their thick versions) should all
be implemented identically in the bindings since they all produce
strings.  Accordingly I have made some Ada bindings changes as
of revision 9259.

Note, there was no way I could get the procedure version of plgfnam to work
with the To_Ada second argument True, so I uniformly set that to False for
all procedure versions of plgdev, plgver, and corresponding thick versions
in analogy with the existing plgfnam procedural version.  Unless the analogy
is wrong for some unknown reason this should be the right thing to do, but
note we do not test the procedural versions of anything but plgfnam so these
API changes are untested by any of our tests.

I also changed the Ada 31st examples to use the new function version of
plgfnam (and its thick counterpart) when outputting results to stderr, and
it no longer has garbage after the output name.

Thus, everything seems to be working correctly with my changes with no
garbage output results for examples 31. However, I am programming by analogy
here with no deep understanding of what I am doing so will you please review
my changes?

N.B. I am pretty sure you could stick strictly with the procedural form of
plgfnam (and thick counterpart) in Ada examples 31 if you used some
string-trimming function to get rid of the trailing garbage for the filename
output to stderr.  However, please do not do that since I think the current
implementation in Ada examples 31 is a better way to go since it exercises
both the procedural and functional forms of plgfnam while also
getting rid of the trailing garbage in stderr.

Alan
__________________________
Alan W. Irwin

Astronomical research affiliation with Department of Physics and Astronomy,
University of Victoria (astrowww.phys.uvic.ca).

Programming affiliations with the FreeEOS equation-of-state implementation
for stellar interiors (freeeos.sf.net); PLplot scientific plotting software
package (plplot.org); the libLASi project (unifont.org/lasi); the Loads of
Linux Links project (loll.sf.net); and the Linux Brochure Project
(lbproject.sf.net).
__________________________

Linux-powered Science
__________________________

------------------------------------------------------------------------------
_______________________________________________
Plplot-devel mailing list
Plplot-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/plplot-devel

Reply via email to