Werner, Good spot. BSD defines these as functions, while C99 specifies that they are macros. Linux seems to include both. check_symbol_exists seems to work anyway. I've also tidied up the checks for underscored versions on windows.
Andrew On Mon, Feb 23, 2009 at 11:30:20PM +0100, Werner Smekal wrote: > Hi Andrew, > > > > I've tidied up the existing isnan support and added isinf as well. This > > needs testing, particularly on windows / other non-linux platforms. > > > > > The addition of isinf leads to warnings for MinGW > > In file included from Z:/DevZone/PLdev/plplot/include/plplotP.h:186, > from Z:\DevZone\PLdev\plplot\src\plbox.c:25: > Z:/DevZone/PLdev/plplot/include/plplot.h:198:1: warning: "isinf" redefined > In file included from Z:/DevZone/PLdev/plplot/include/plplotP.h:111, > from Z:\DevZone\PLdev\plplot\src\plbox.c:25: > C:/DevZone/MinGW-3.4.5/bin/../lib/gcc/mingw32/3.4.5/../../../../include/math.h:330:1: > > warning: this is the location of the previous > definition > > The problem is, that we check if the function isinf() exits in > plplot.cmake, but isinf is actually not a (real) function, but a macro > defined in math.h > > #define isinf(x) (fpclassify(x) == FP_INFINITE) > > so isinf isn't found in any library. > > include(CheckSymbolExists) > check_symbol_exists(isinf math.h HAVE_ISINF) > > works though. Is anybody against such a change? > > Regards, > Werner > > -- > Dr. Werner Smekal > Institut fuer Allgemeine Physik > Technische Universitaet Wien > Wiedner Hauptstr 8-10 > A-1040 Wien > Austria > DVR-Nr: 0005886 > > email: [email protected] > web: http://www.iap.tuwien.ac.at/~smekal > phone: +43-(0)1-58801-13463 (office) > +43-(0)1-58801-13469 (laboratory) > fax: +43-(0)1-58801-13499 > > > ------------------------------------------------------------------------------ > Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA > -OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise > -Strategies to boost innovation and cut costs with open source participation > -Receive a $600 discount off the registration fee with the source code: SFAD > http://p.sf.net/sfu/XcvMzF8H > _______________________________________________ > Plplot-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/plplot-devel > ------------------------------------------------------------------------------ Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA -OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise -Strategies to boost innovation and cut costs with open source participation -Receive a $600 discount off the registration fee with the source code: SFAD http://p.sf.net/sfu/XcvMzF8H _______________________________________________ Plplot-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/plplot-devel
